Skip to content

Conversation

PabloRoque
Copy link
Contributor

@PabloRoque PabloRoque commented Aug 13, 2025

Description

MMMPlotSuite.plot_sensitivity_analysis handles multidimensional MMMs

Checklist


📚 Documentation preview 📚: https://pymc-marketing--1886.org.readthedocs.build/en/1886/

@github-actions github-actions bot added the MMM label Aug 13, 2025
@PabloRoque PabloRoque marked this pull request as ready for review August 13, 2025 10:47
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 94.68085% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.11%. Comparing base (b3865fa) to head (75b5e5a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pymc_marketing/mmm/plot.py 94.68% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1886      +/-   ##
==========================================
- Coverage   92.13%   92.11%   -0.02%     
==========================================
  Files          65       65              
  Lines        7638     7690      +52     
==========================================
+ Hits         7037     7084      +47     
- Misses        601      606       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PabloRoque PabloRoque requested a review from juanitorduz August 13, 2025 10:49
@juanitorduz
Copy link
Collaborator

Thanks @PabloRoque ! Can we add some tests :) ?

@github-actions github-actions bot added the tests label Aug 19, 2025
@PabloRoque
Copy link
Contributor Author

@juanitorduz Added some tests to test_sensitivity_analysis.py

@PabloRoque PabloRoque requested a review from cetagostini August 19, 2025 14:31
@cetagostini
Copy link
Contributor

Probably not relevant at any case to stop the merge, but I'm updating this method in #1899

@PabloRoque
Copy link
Contributor Author

@cetagostini Do you see conflicts?

This only modifies a method in MMMPlotSuite. I don't see changes there in #1899.

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PabloRoque

@juanitorduz
Copy link
Collaborator

@carlosagostini is it ok if we merge this one?

Copy link
Contributor

@cetagostini cetagostini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we are good to go!

@cetagostini cetagostini merged commit 26d1d2a into pymc-labs:main Aug 21, 2025
54 of 55 checks passed
@PabloRoque PabloRoque deleted the multidim-plot-sensitivity-analysis branch August 23, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants