-
Notifications
You must be signed in to change notification settings - Fork 314
Multidimensional support in plot_sensitivity_analysis #1886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multidimensional support in plot_sensitivity_analysis #1886
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1886 +/- ##
==========================================
- Coverage 92.13% 92.11% -0.02%
==========================================
Files 65 65
Lines 7638 7690 +52
==========================================
+ Hits 7037 7084 +47
- Misses 601 606 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks @PabloRoque ! Can we add some tests :) ? |
@juanitorduz Added some tests to |
Probably not relevant at any case to stop the merge, but I'm updating this method in #1899 |
@cetagostini Do you see conflicts? This only modifies a method in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PabloRoque
@carlosagostini is it ok if we merge this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we are good to go!
Description
MMMPlotSuite.plot_sensitivity_analysis
handles multidimensional MMMsChecklist
pre-commit.ci autofix
to auto-fix.📚 Documentation preview 📚: https://pymc-marketing--1886.org.readthedocs.build/en/1886/